Migrate Vue language server to 3.x #1920
Conversation
|
Now looks like problem with LSP4E, during processing for a moment in communication logs I see invalid file uris (relative to project root rather than absolute) |
|
I even found reason: typescript-language-server/typescript-language-server#989 |
zulus
force-pushed
the
vue3
branch
3 times, most recently
from
1fd902b to
32e1fcf
Compare
| @Override | ||
| public String toString() { | ||
| return "VUE Language Server: " + super.toString(); | ||
| public void handleMessage(Message message, LanguageServer languageServer, URI rootURI) { |
There was a problem hiding this comment.
If someone have know howto move this to VueClientImpl I'll be happy to do this
|
|
||
| @Override | ||
| public CompletableFuture<List<Object>> configuration(ConfigurationParams params) { | ||
| return CompletableFuture.supplyAsync(() -> { |
There was a problem hiding this comment.
Vue consume same configuration as HTML/CSS LS, so I just copy/paste
| @Test | ||
| public void testJSXFile() throws Exception { | ||
| final IFile jsconfig = project.getFile("jsconfig.json"); | ||
| jsconfig.create("{\"compilerOptions\":{\"jsx\":\"react\"}}".getBytes(), true, false, null); |
There was a problem hiding this comment.
This fix broken test with new typescript server
Signed-off-by: Dawid Pakuła <[email protected]>
|
/request-license-review |
Workflow run (with attached summary files): |
|
/request-license-review |
Workflow run (with attached summary files): |
|
[ ] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23371 . |
|
License check problems: eclipse-dash/dash-licenses#448 |
vrubezhny
left a comment
vrubezhny
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks Dawid!
The only thing is that usually we use spaces for tabs...
Not a big problem, but keeping this practice consistent helps avoiding the situations when you need to review a big file (all red and green) when the only one valuable line is actually added/removed/changed.
vrubezhny
merged commit a8d7cdb
into
eclipse-wildwebdeveloper:master
|
Arghhh I didn't notice that, sorry. Normally I just use Eclipse for Commiters settings and project scope .settings if available. Could you commit correct JDT formatter settings for this project? |
3 participants
Initial implementation: